Custom OnSurfaceCount issue

[tree1891]

Navigating away from the screen with ViewPager and dots and then navigating back, custom OnSurfaceCount not restored and layout broken.
ex: setOnSurfaceCount(1);

[shuhart]

I try to reproduce and no luck. Could you please post a code to reproduce?

[shuhart]

A bug related with broken state after updating onSurfaceCount is fixed. Not sure whether it's related to your issue but try version 1.0.7.

[tree1891]

It is not fixed and grow worse.
it is not center aligned and moving while swiping on default OnSurfaceCount.

BubblePageIndicator pageIndicator = view.findViewById(R.id.page_indicator);
pageIndicator.setViewPager(viewPager);
//pageIndicator.setOnSurfaceCount(3);
pageIndicator.setEnabled(false);

at the beginning

after swiping left and right repeatedly

[shuhart]

Could you post the code to reproduce?

…

On Thu, Mar 1, 2018, 20:48 tree1891 ***@***.***> wrote: It is not fixed and grow worse. it is not center aligned and moving while swiping. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFDzvmRX5TxYjyHTLAsy3mZ0lOE9w-pJks5taApXgaJpZM4SLXkA> .

[tree1891]

sorry, it is not possible.

[shuhart]

I need to get an idea of what happening in your case. How do your configure BubblePagerIndicator and how is everything tied to the lifecycle? How do you updating indicator or a pager adapter? It's hard to guess what is happening just from the words "it's not working as I expected".

…

On Thu, Mar 1, 2018, 21:20 tree1891 ***@***.***> wrote: sorry, it is not possible. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFDzvgJwYF5pxKzqRrujcD4y8q17084cks5taBGngaJpZM4SLXkA> .

[tree1891]

<LinearLayout
	android:layout_width="match_parent"
	android:layout_height="wrap_content"
	android:layout_alignBottom="@+id/viewpager"
	android:layout_centerHorizontal="true"
	android:orientation="vertical"
	android:paddingBottom="20dp">

	<com.shuhart.bubblepagerindicator.BubblePageIndicator
		android:id="@+id/page_indicator"
		android:layout_width="wrap_content"
		android:layout_height="wrap_content"
		android:layout_alignParentBottom="true"
		android:layout_centerInParent="true"
		android:layout_gravity="center_horizontal"
		app:fillColor="@color/azure"
		app:pageColor="#d8d8d8"
		app:radius="4dp" />

</LinearLayout>

BubblePageIndicator pageIndicator = view.findViewById(R.id.page_indicator);
pageIndicator.setViewPager(viewPager);
//pageIndicator.setOnSurfaceCount(3);
pageIndicator.setEnabled(false);

After init, there is no any update for pageIndicator, but not for viewpager's adapter.

[shuhart]

Do yo update an adapter several times or only once? It happens not immediately after init, right? Maybe, after a network request?

…

On Fri, Mar 2, 2018, 08:03 tree1891 ***@***.***> wrote: <LinearLayout android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_alignBottom="@+id/viewpager" android:layout_centerHorizontal="true" android:orientation="vertical" android:paddingBottom="20dp"> <com.shuhart.bubblepagerindicator.BubblePageIndicator android:id="@+id/page_indicator" android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_alignParentBottom="true" android:layout_centerInParent="true" android:layout_gravity="center_horizontal" ***@***.***/azure" app:pageColor="#d8d8d8" app:radius="4dp" /> </LinearLayout> <LinearLayout android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_alignBottom="@+id/viewpager" android:layout_centerHorizontal="true" android:orientation="vertical" android:paddingBottom="20dp"> <com.shuhart.bubblepagerindicator.BubblePageIndicator android:id="@+id/page_indicator" android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_alignParentBottom="true" android:layout_centerInParent="true" android:layout_gravity="center_horizontal" ***@***.***/azure" app:pageColor="#d8d8d8" app:radius="4dp" /> </LinearLayout> BubblePageIndicator pageIndicator = view.findViewById(R.id.page_indicator); pageIndicator.setViewPager(viewPager); //pageIndicator.setOnSurfaceCount(3); pageIndicator.setEnabled(false); After init, there is no any update for pageIndicator, but not for viewpager's adapter. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFDzvjzfKB833A8uRj3QMzv67K3ZMb-dks5taKhZgaJpZM4SLXkA> .

[tree1891]

Yes, right, it will be updated every on resume or by other action

[shuhart]

Thanks, I'll look into that.

…

On Fri, Mar 2, 2018, 08:11 tree1891 ***@***.***> wrote: Yes, right, it will be updated on resume. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFDzvnRzDTZozHBInis8ZVDoOgo3xIGVks5taKo7gaJpZM4SLXkA> .

[shuhart]

Some related to this bugs were fixed in 1.0.8. Try it out and let me know if everything is OK.

[tree1891]

With custom OnSurfaceCount(ex: 3), it does not work at the beginning(viewpager is not empty).
Sliding in viewpager does not change indicator.
Navigating away and then navigating back, it does work.

It is also not center aligned.

[shuhart]

Fixed in 1.0.10

[tree1891]

It does work!
Thank you very much!

[shuhart]

Cool)

…

On Fri, Mar 2, 2018, 12:13 tree1891 ***@***.***> wrote: It does work! Thank you very much! — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFDzvpcqAK5WPPVMDCoY00zR81iWQUw6ks5taOMZgaJpZM4SLXkA> .