Skip to content

Commit

Permalink
refactor(connect_callee.go): remove pointer receiver from Call method…
Browse files Browse the repository at this point in the history
… to improve semantics

refactor(connect_service.go): remove pointer receiver from Call method to improve semantics
feat(error_callee.go): add new errorCallee struct to simulate an error in the callee
refactor(fake_callee.go): remove pointer receiver from Call method to improve semantics
refactor(http_callee.go): remove pointer receiver from Call method to improve semantics
refactor(http_service.go): remove pointer receiver from Handler method to improve semantics
feat(main.go): add support for errorCallee mode to simulate an error in the callee
  • Loading branch information
shumkovdenis committed May 16, 2023
1 parent f77eb19 commit fc4aaf3
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 5 deletions.
2 changes: 1 addition & 1 deletion connect_callee.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func NewConnectCallee(cfg Config) *connectCallee {
return &connectCallee{client: client}
}

func (c *connectCallee) Call(ctx context.Context, msg Message) (Message, error) {
func (c connectCallee) Call(ctx context.Context, msg Message) (Message, error) {
req := connect.NewRequest(&examplePb.CallRequest{
Message: msg.Content,
})
Expand Down
2 changes: 1 addition & 1 deletion connect_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func NewConnectService(cfg Config, caller Callee) error {
)
}

func (s *connectService) Call(
func (s connectService) Call(
ctx context.Context,
req *connect.Request[example.CallRequest],
) (*connect.Response[example.CallResponse], error) {
Expand Down
16 changes: 16 additions & 0 deletions error_callee.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package main

import (
"context"
"errors"
)

type errorCallee struct{}

func NewErrorCallee() *errorCallee {
return &errorCallee{}
}

func (c errorCallee) Call(ctx context.Context, msg Message) (Message, error) {
return Message{}, errors.New("error in callee")
}
2 changes: 1 addition & 1 deletion fake_callee.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ func NewFakeCallee() *fakeCallee {
return &fakeCallee{}
}

func (c *fakeCallee) Call(ctx context.Context, msg Message) (Message, error) {
func (c fakeCallee) Call(ctx context.Context, msg Message) (Message, error) {
return msg, nil
}
2 changes: 1 addition & 1 deletion http_callee.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func NewHTTPCallee(cfg Config) *httpCallee {
}
}

func (c *httpCallee) Call(ctx context.Context, msg Message) (Message, error) {
func (c httpCallee) Call(ctx context.Context, msg Message) (Message, error) {
data, err := json.Marshal(&msg)
if err != nil {
return Message{}, fmt.Errorf("failed to marshal message: %w", err)
Expand Down
2 changes: 1 addition & 1 deletion http_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func NewHTTPService(cfg Config, caller Callee) error {
return server.Listen(fmt.Sprintf(":%d", cfg.Port))
}

func (s *httpService) Handler(c *fiber.Ctx) error {
func (s httpService) Handler(c *fiber.Ctx) error {
ctx := c.UserContext()
logger := log.Ctx(ctx)

Expand Down
2 changes: 2 additions & 0 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ func main() {
callee = NewHTTPCallee(cfg)
} else if cfg.Callee.Mode == "connect" {
callee = NewConnectCallee(cfg)
} else if cfg.Callee.Mode == "error" {
callee = NewErrorCallee()
} else {
callee = NewFakeCallee()
}
Expand Down

0 comments on commit fc4aaf3

Please sign in to comment.