Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HashName #6

Merged
merged 2 commits into from
Feb 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions allennlp_dataframe_mapper/transforms/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from allennlp_dataframe_mapper.transforms.base import RegistrableTransform # NOQA
from allennlp_dataframe_mapper.transforms.hash_name import HashName # NOQA
from allennlp_dataframe_mapper.transforms.preprocessing import ( # NOQA
FlattenTransformer,
LabelEncoder,
Expand Down
27 changes: 27 additions & 0 deletions allennlp_dataframe_mapper/transforms/hash_name.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import hashlib
from typing import Optional

import numpy as np
from allennlp_dataframe_mapper.transforms import RegistrableTransform
from overrides import overrides


@RegistrableTransform.register("hashname")
class HashName(RegistrableTransform):
def __init__(self, ext: Optional[str] = None) -> None:
super().__init__()
self._ext = ext

def to_hash_name(self, url: str) -> str:
hash_name = hashlib.md5(url.encode("utf8")).hexdigest()
if self._ext is not None:
return hash_name + self._ext
return hash_name

@overrides
def fit(self, *args, **kwargs):
return self

@overrides
def transform(self, X):
return np.vectorize(self.to_hash_name)(X)
3 changes: 3 additions & 0 deletions test_fixtures/transforms/hash_name/hash_name.jsonnet
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"type": "hashname"
}
2 changes: 2 additions & 0 deletions tests/transforms/base_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ def test_registrable_transform(self) -> None:
"label-encoder",
"logarithmer",
"flatten",
"hashname",
]
)

Expand All @@ -25,3 +26,4 @@ def test_registrable_transform(self) -> None:
assert RegistrableTransform.by_name("label-encoder").__name__ == "LabelEncoder"
assert RegistrableTransform.by_name("logarithmer").__name__ == "Logarithmer"
assert RegistrableTransform.by_name("flatten").__name__ == "FlattenTransformer"
assert RegistrableTransform.by_name("hashname").__name__ == "HashName"
60 changes: 60 additions & 0 deletions tests/transforms/hash_name_test.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
import numpy as np
import pytest
from allennlp.common import Params
from allennlp_dataframe_mapper.common.testing import AllenNlpDataFrameMapperTestCase
from allennlp_dataframe_mapper.transforms import HashName, RegistrableTransform


class TestHashName(AllenNlpDataFrameMapperTestCase):
def test_hash_name_from_params(self):
params = Params.from_file(
self.FIXTURES_ROOT / "transforms" / "hash_name" / "hash_name.jsonnet"
)
transform = RegistrableTransform.from_params(params=params)
assert isinstance(transform, HashName)

@pytest.mark.parametrize(
"url, expected",
(
("http://example.com/", "a6bf1757fff057f266b697df9cf176fd"),
("http://abehiroshi.la.coocan.jp/", "99daa109463db188c4160ee06a6ca8f7"),
),
)
def test_hash_name(self, url, expected):
hash_name = HashName()
url_hashed = hash_name.transform(url)

expected_np = np.array(expected)
assert np.array_equal(url_hashed, expected_np)

def test_hash_names(self):

urls = ["http://example.com/", "http://abehiroshi.la.coocan.jp/"]
hash_name = HashName()
url_hashed = hash_name.transform(urls)

expected = np.array(
[
"a6bf1757fff057f266b697df9cf176fd",
"99daa109463db188c4160ee06a6ca8f7",
]
)
assert np.array_equal(url_hashed, expected)

@pytest.mark.parametrize(
"ext, url, expected",
(
(".png", "http://example.com/", "a6bf1757fff057f266b697df9cf176fd"),
(
".jpg",
"http://abehiroshi.la.coocan.jp/",
"99daa109463db188c4160ee06a6ca8f7",
),
),
)
def test_hash_name_with_ext(self, ext, url, expected):
hash_name = HashName(ext=ext)
url_hashed = hash_name.transform(url)

expected_np = np.array(expected + ext)
assert np.array_equal(url_hashed, expected_np)