Add support for visualizing and updating dependencies (within Gopkg.toml constraints) in dep-enabled projects. #82
Conversation
This is the first naive implementation. It reads Gopkg.lock file directly to figure out the base versions of all dependencies, and uses usual logic to figure out latest versions of each dependency. This in turn bypasses the constraints set in Gopkg.toml file. That is not acceptable because it's not helpful to the user to see these updates without distinction of what is within the Gopkg.toml constraints and without. Also, the update button will do the wrong thing, as it updates via dep ensure -update which does respect Gopkg.toml constraints. Helps #81.
This change implements correct behavior, where the displayed updates are within the Gopkg.toml constraints as determined by dep status command. We defer the work of determining remotely available updates to dep, since there's no easy way to perform constraint checking on our end. For now, this is a simple solution that works. In the future, a more elaborate setup can be considered, if needed to have better performance or implement certain additional features. Resolves #81.
![gopherci[bot]](https://avatars.githubusercontent.com/in/889?s=60&v=4){kind=small}
| Dir string | ||
| } | ||
|
|
||
| func (d Dep) Update(repo *gps.Repo) error { |
There was a problem hiding this comment.
golint: exported method Dep.Update should have comment or be unexported
There was a problem hiding this comment.
Ignoring because this implements an interface, and I don't want to copy/paste the interface documentation into multiple places, causing it to more easily fall out of date.
I could write a // Update implements Updater interface., but it doesn't seem worth it at this point.
|
This is great, going to give it a test shortly. Did you want to update the README.md with a similar example to the PR's? |
Sorry, I don't understand what you mean by that. Can you rephrase? README.md is already updated to include the new |
Argh, yes, sorry, I must have skipped over that file when I looked, ignore my comment! |
This PR adds support for
depand resolves #81. /cc @sdboyer @bits01 @bradleyfalzonA new
-depflag is added. Using it requiresdepbinary to be available in PATH. When-depflag is set to point to aGopkg.tomlfile of adep-enabled project, it runsdep statusin the containing directory to determine available updates (withinGopkg.tomlconstraints) and then displays them in a visual form.The Update (and Update All) buttons are functional. Pressing them executes
dep ensure -update {root}command in same directory, causing the update to be applied.E.g.: