Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserIds field should be named UserIDs. #11

Closed
dmitshur opened this issue Jul 9, 2017 · 0 comments
Closed

UserIds field should be named UserIDs. #11

dmitshur opened this issue Jul 9, 2017 · 0 comments
Labels
bug

Comments

@dmitshur
Copy link
Member

dmitshur commented Jul 9, 2017 •
edited

See https://github.com/shurcooL/githubql/blob/0b00ca5879d0039d6c5b952b12d/input.go#L367.

It should be UserIDs to follow Go style.

This is a case that is not correctly handled in caseconv.LowerCamelCaseToMixedCaps.
@dmitshur dmitshur added the bug label Jul 9, 2017
@dmitshur dmitshur changed the title RequestReviewsInput.UserIds field should be named UserIDs. UserIds field should be named UserIDs. Jul 9, 2017
dmitshur added a commit to shurcooL/graphql that referenced this issue Jul 25, 2017
@dmitshur
ident: Handle plural form of ID initialism special case.
fada01f 
Unfortunately, for now, handling plural form of ID initialism is a
special case. Plural forms of initialisms are rare and I can't think of
others that would need this handling, so this is good enough for now.
If that changes, we might want to find a more general solution.

Improve internal docs to refer to lower letters as "lower" and upper
letters as "Upper". That helps make it more readable.

Helps shurcooL/githubv4#11.
mattstern31 pushed a commit to mattstern31/graphql-go-client-internal that referenced this issue Nov 10, 2022
ident: Handle plural form of ID initialism special case.
3f783c3 
Unfortunately, for now, handling plural form of ID initialism is a
special case. Plural forms of initialisms are rare and I can't think of
others that would need this handling, so this is good enough for now.
If that changes, we might want to find a more general solution.

Improve internal docs to refer to lower letters as "lower" and upper
letters as "Upper". That helps make it more readable.

Helps shurcooL/githubv4#11.
totalys added a commit to totalys/go-graphql-client that referenced this issue Nov 17, 2022
@totalys
ident: Handle plural form of ID initialism special case.
b2055ae 
Unfortunately, for now, handling plural form of ID initialism is a
special case. Plural forms of initialisms are rare and I can't think of
others that would need this handling, so this is good enough for now.
If that changes, we might want to find a more general solution.

Improve internal docs to refer to lower letters as "lower" and upper
letters as "Upper". That helps make it more readable.

Helps shurcooL/githubv4#11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmitshur