Create generator and generate enum.go. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generating all of enum.go has proven that this approach won't work. There are many name collisions, because different enum types share same enum value names. # github.com/shurcooL/githubql ./enum.go:71: CreatedAt redeclared in this block previous declaration at ./enum.go:17 ./enum.go:111: Open redeclared in this block previous declaration at ./enum.go:8 ./enum.go:112: Closed redeclared in this block previous declaration at ./enum.go:9 ./enum.go:120: CreatedAt redeclared in this block previous declaration at ./enum.go:71 ./enum.go:121: UpdatedAt redeclared in this block previous declaration at ./enum.go:18 ./enum.go:149: CreatedAt redeclared in this block previous declaration at ./enum.go:120 ./enum.go:150: UpdatedAt redeclared in this block previous declaration at ./enum.go:121 ./enum.go:152: Name redeclared in this block previous declaration at ./enum.go:19 ./enum.go:170: Open redeclared in this block previous declaration at ./enum.go:111 ./enum.go:171: Closed redeclared in this block previous declaration at ./enum.go:112 ./enum.go:171: too many errors
The duplicate identifiers are manually commented out for now while I decide on which of multiple approaches to use to resolve the issue. Fixes build.
This was referenced Jun 21, 2017
dmitshur
added a commit
that referenced
this pull request
Jul 2, 2017
Go with solution 1, as described in #8. Solution 1 is the simplest, most predictable, and least controversial option. Its only downfall are the verbose enum value identifiers, but it suffers from least other problems. Since the API of the library is not frozen yet, if another solution is found which is determined to be better overall, we can still improve this. Regenerate with: go generate ./... Updates #8. Follows #7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following TODO comment in enum.go:
Generating all of enum.go has proven that this approach won't work. There are many name collisions, because different enum types share same enum value names.
The duplicate identifiers are manually commented out for now while I decide on which of multiple approaches to use to resolve the issue.