Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose constructQuery to public function #34

Open
remones opened this Issue Nov 19, 2018 · 3 comments

Comments

3 participants
@remones
Copy link

remones commented Nov 19, 2018

In my case, the server that I depend on should be mocked, and I need to verify the request in the HTTP handler, so I think it's better to expose some tool functions which can help us to encode/decode.

@adamgoose

This comment has been minimized.

Copy link

adamgoose commented Dec 30, 2018

I could benefit from this as well. See #27 (comment)

@dmitshur

This comment has been minimized.

Copy link
Member

dmitshur commented Apr 11, 2019

I'm warming up to this idea, but in a slightly different form.

I think it might be a good idea to expose some of the graphql internals (in this project), but in another location. The idea would be to make it possible to assemble a relatively high level GraphQL client (preferably tailored for a specific GraphQL server) library from the low-level building blocks.

I need to think it through some more and see what would be a good location for it. It's important to keep the boundary between the internals and the high level-client clear. I'll post updates here when I make more progress.

@remones

This comment has been minimized.

Copy link
Author

remones commented Apr 13, 2019

Thanks for your reply. I'm looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.