markdown: change isNumber to report negatively on empty input (#46)

This change fixes an edge case where an escaped period after a link did not get get unescaped. Escaping the period in that context is not necessary, so it's helpful to unescape it and produce cleaner output.
shurcooL · Mar 11, 2019 · b3016f8 · b3016f8
1 parent 0ad3159
commit b3016f8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/markdown/main.go b/markdown/main.go
@@ -346,7 +346,7 @@ func isNumber(data []byte) bool {
 			return false
 		}
 	}
-	return true
+	return len(data) > 0
 }
 
 func needsEscaping(text []byte, lastNormalText string) bool {

diff --git a/markdown/testdata/url.golden.md b/markdown/testdata/url.golden.md
@@ -0,0 +1,3 @@
+Lorem [ipsum](https://www.example.com).
+
+Lorem [ipsum](https://www.example.com).
diff --git a/markdown/testdata/url.in.md b/markdown/testdata/url.in.md
@@ -0,0 +1,3 @@
+Lorem [ipsum](https://www.example.com).
+
+Lorem [ipsum](https://www.example.com)\.