Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate and parse incoming gossip messages #47

Closed
jannikluhn opened this issue Sep 22, 2021 · 0 comments · Fixed by #62
Closed

Validate and parse incoming gossip messages #47

jannikluhn opened this issue Sep 22, 2021 · 0 comments · Fixed by #62
Assignees

Comments

@jannikluhn
Copy link
Contributor

  • parse them and the included data types
  • convert them to a struct (one per message type)
  • the struct should conform to an interface (c.f. gossip message interface already defined in shmsg)
  • reject messages that are not parsable or have easily detectable invalid values

The libp2p validation interface should be able to do both parsing and validation at the same time. If not, revise.

@jannikluhn jannikluhn added this to To do in Rolling Shutter via automation Sep 22, 2021
@cducrest cducrest self-assigned this Sep 30, 2021
@cducrest cducrest moved this from To do to In progress in Rolling Shutter Sep 30, 2021
Rolling Shutter automation moved this from In progress to Done Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants