Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sending decryption signatures multiple times #70

Closed
jannikluhn opened this issue Oct 11, 2021 · 2 comments
Closed

Avoid sending decryption signatures multiple times #70

jannikluhn opened this issue Oct 11, 2021 · 2 comments
Assignees

Comments

@jannikluhn
Copy link
Contributor

At the moment, sending a new aggregated decryption signature is triggered by receiving a new unaggregated signature (and we have enough of them in the db). This means we send many unnecessary ones.

  • store aggregated signatures in db table (one per hash)
  • only broadcast signature when none is in db already
@jannikluhn jannikluhn added this to To do in Rolling Shutter via automation Oct 11, 2021
@cducrest cducrest self-assigned this Oct 11, 2021
@cducrest cducrest moved this from To do to In progress in Rolling Shutter Oct 11, 2021
@cducrest
Copy link
Contributor

Do we want to handle received aggregated signatures? We could store them in the db and not need to broadcast them (as we already broadcast them when we received them). As a result we would not need create a new aggregated signature.

It should rarely happen that we ever receive an aggregated signature without being able to create one ourselves (or having already created one)since our peers should have sent us every signature they have seen.

I decide not to handle this case for now.

@jannikluhn
Copy link
Contributor Author

I think we should at some point, but not now. Ideally, every node waits a random amount of time before creating the aggregated signature so that it (a) includes signatures of mos nodes and (b) only one node generates it.

It should rarely happen that we ever receive an aggregated signature without being able to create one ourselves (or having already created one)since our peers should have sent us every signature they have seen.

I think it will happen often because of symmetry: every node is equal, so every node will receive enough signatures at roughly the same time, so every node will send the aggregated signature at roughly the same time. That is, unless latency or connectivity differences become too big. But we'll see.

Rolling Shutter automation moved this from In progress to Done Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants