Improves hover detail placement when space is tight #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layout error for hover detail elements is now checked for both left and right alignment. Then the alignment with the least error is used.
|
Pulled this into our development branch, and can confirm it works. |
dchester
added a commit
that referenced
this pull request
Oct 22, 2013
Improves hover detail placement when space is tight
|
Looks good -- thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout error for hover detail elements is now checked for both left and right alignment. Then the alignment with the least error is used.
Sorry for the churn on this, after dismissing narrow charts in the last pull request, I immediately ran into a need to handle them more correctly.