Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install cargo-binstall as binary. Add --no-test and version options. #11

Merged
merged 6 commits into from Jul 31, 2023
Merged

Install cargo-binstall as binary. Add --no-test and version options. #11

merged 6 commits into from Jul 31, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Jul 14, 2023 •
edited

This speeds up the installation step from some minutes to ~4s.
Also cleanup and add more flags.
Updated documentation.

I have tested the changes here: https://github.com/jonaro00/TabPortal/actions (run 10 - 12)

@jonaro00 jonaro00 mentioned this pull request Jul 14, 2023
Closed
oddgrd
oddgrd approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking @jonaro00, thanks! I left a minor comment, but LGTM! 🥳

README.md Show resolved Hide resolved
@oddgrd oddgrd merged commit 409c376 into shuttle-hq:main Jul 31, 2023
@jonaro00 jonaro00 deleted the feat/install-binaries branch July 31, 2023 15:08
@jonaro00 jonaro00 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddgrd oddgrd oddgrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonaro00 @oddgrd