Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Logging still happens even with shuttle_runtime --no-default-features flag #1586

Open
1 task done
joshua-mo-143 opened this issue Jan 25, 2024 · 2 comments
Open
1 task done
Labels
S-Triage Awaiting decision for what to do T-Bug Something isn't working

Comments

@joshua-mo-143
Copy link
Member

What happened?

Installing shuttle_runtime with no default features still causes logging to happen. Adding a custom subscriber with timestamps causes double timestamping.

Discord conversation reference: https://discord.com/channels/803236282088161321/953005742842069013/1200211085253427280

Version

v0.37.0

Which operating system(s) are you seeing the problem on?

Linux

Which CPU architectures are you seeing the problem on?

x86_64

Relevant log output

(see the referenced discord conversation)

Duplicate declaration

  • I have searched the issues and there are none like this.
@joshua-mo-143 joshua-mo-143 added S-Triage Awaiting decision for what to do T-Bug Something isn't working labels Jan 25, 2024
@oddgrd
Copy link
Contributor

oddgrd commented Jan 26, 2024

That logs are recorded without the default tracing subscriber is expected, we capture any logs written to stdout by an application, and this is documented. We could add a note about the timestamps as explained by Johan in the linked thread, however, and perhaps update the example custom subscriber to not record timestamps.

It's also the case that if you don't write to stdout and rather export to e.g. Datadog, the logs sent to Datadog will not have extra timestamps.

@oddgrd
Copy link
Contributor

oddgrd commented Jan 26, 2024

We could also consider making it possible to opt-out of the timestamps set by us, but that would require some further investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Triage Awaiting decision for what to do T-Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants