Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deny(warnings) annotation #36

Closed
christos-h opened this issue Jul 7, 2021 · 2 comments
Closed

Remove the deny(warnings) annotation #36

christos-h opened this issue Jul 7, 2021 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@christos-h
Copy link
Member

christos-h commented Jul 7, 2021 •
edited

Describe the bug
Not a bug - but the deny(warnings) annotation is considered an anti-pattern.

The deny(warnings) annotation should be removed from the crates synth synth-gen and synth-core.

There should instead be explicit warning checks in CI with something like RUSTFLAGS="-D warnings" cargo build.
@christos-h christos-h added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed and removed bug Something isn't working labels Jul 7, 2021
@robert-monk
Copy link
Contributor

Hi, I would like to help out with this issue!

@christos-h
Copy link
Member Author

Hey! That would be much appreciated.

Let me know if you need anything :)

@robert-monk robert-monk mentioned this issue Jul 20, 2021
Merged
@juniorbassani juniorbassani mentioned this issue Jul 28, 2021
Closed
@llogiq llogiq closed this as completed Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@llogiq @christos-h @robert-monk