chore: Remove instances of deny(warnings) annotation #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request. However, we'd still like to fail our CI actions if any warnings occur. So to make this complete, you should look into all github actions that call |
|
@robert-monk sorry for letting you wait, do you need anything from my side to follow this through? |
|
@llogiq everything is ok, just getting to it now! |
|
Great! Thank you for seeing this through. 👍 |
|
Error seems a flaky test, which is certainly unrelated. Weird, I thought I had removed all indeterminism. Thank you for helping our project! ❤️ |
juniorbassani
pushed a commit
to juniorbassani/synth
that referenced
this pull request
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the deny(warnings) annotations as mentioned in #36. Only found the annotation in synth and synth-core.