Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock Jinja2 2.8.1 #1285

Open
tulimaki opened this issue Jun 12, 2018 · 0 comments
Open

Unlock Jinja2 2.8.1 #1285

tulimaki opened this issue Jun 12, 2018 · 0 comments

Comments

@tulimaki
Copy link
Contributor

tulimaki commented Jun 12, 2018

Front app is now locked to jinja2 2.8.1 since the complex inheritance with macros.

Now front extends those macros here like this
{% extends "shuup/front/macros/theme/navigation.jinja" %}

And what this could be is that this file has the customized macros and that “extends” are for default/fallback macros and each macro would have “if exists” wrapped around it. At least this solution would still allow overriding single macros from default front for customized themes.

The current front app works but after updating 2.9.0 you can reproduce this easily by checking the classic gray menu extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants