Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Add better callback support for addons #1292

Open
Pikkupomo opened this issue Jun 18, 2018 · 0 comments
Open

Suggestion: Add better callback support for addons #1292

Pikkupomo opened this issue Jun 18, 2018 · 0 comments

Comments

@Pikkupomo
Copy link
Contributor

Addons should be able to provide callback functionality without declaring URL's.

This would help with the following:

  • Addons don't have to provide URL's for callbacks
  • Less change for duplicate URL's in the front of the store
  • One place for debug

Idea for Solution

www.shuup-shop.com/callback/<identifier>

Addon would then declare callback_providers and declare my_addon in the provider:

class MyAddonCallbackProvider(CallbackProvider):
	identifier = "my_addon"

	def callback(self, request, *args, **kwargs):
		pass

after that the URL www.shop.com/callback/my_addon would call MyAddonCallbackProvider:callback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant