Core: option to create payments with REST API #342

tulimaki · 2016-02-05T02:45:52Z

Add create_payment detail route to OrderViewSet
Add custom PaymentSerializer with amount_value,
currency, payment_identifier and description as fields.

Refs SHOOP-2117 / SHOOP-1973

anders-jenkins · 2016-02-05T02:59:18Z

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1550/
Test PASSed.

anders-jenkins · 2016-02-05T03:32:22Z

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1551/
Test PASSed.

anders-jenkins · 2016-02-05T03:43:30Z

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1552/
Test PASSed.

anders-jenkins · 2016-02-05T19:43:10Z

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1553/
Test PASSed.

anders-jenkins · 2016-02-05T21:12:19Z

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1554/
Test PASSed.

akx · 2016-02-08T07:48:51Z

This should mention it's about the REST API, not just "API".

Also, it's missing tests.

akx · 2016-02-08T08:14:45Z

Are payments currently retrievable via the API?

Pikkupomo · 2016-02-08T11:26:00Z

like @akx said, add tests please

tulimaki · 2016-02-08T16:33:28Z

@akx payments are not currently retrievable via the REST API

anders-jenkins · 2016-02-08T19:12:58Z

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1560/
Test PASSed.

anders-jenkins · 2016-02-08T21:32:03Z

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1561/
Test PASSed.

akx · 2016-02-09T16:14:36Z

shoop/core/api/orders.py

+                data["payment_identifier"],
+                data.get("description", "")
+            )
+            return Response({'status': 'order is now fully paid'})


I think a return code of 201 ("Created") would be more appropriate here?

anders-jenkins · 2016-02-09T18:58:09Z

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1564/
Test PASSed.

akx · 2016-02-10T09:31:37Z

@tulimaki Now that you have a simple serializer for payments, it should be trivial to add something like payments = PaymentSerializer(many=True, read_only=True) to the OrderSerializer to make the payments accessible via the REST API.

tulimaki · 2016-02-10T20:58:15Z

Payments is now available via REST API. Since Payment didn't have currency I added currency property for it. I guess that it's OK.

anders-jenkins · 2016-02-10T21:08:03Z

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1566/
Test PASSed.

anders-jenkins · 2016-02-10T22:43:15Z

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1570/
Test PASSed.

tulimaki · 2016-03-01T15:48:26Z

retest this please

suutari-ai · 2016-03-02T08:54:27Z

shoop/core/models/_payments.py

+
+    @property
+    def currency(self):
+        return self.amount.currency


What's the point of this? Why can't the API user just use payment.amount.currency (or payment.foreign_amount.currency)?

* Add create_payment detail route to OrderViewSet * add set_fully_paid detail route to OrderViewSet * Add PaymentSerializer with amount_value, payment_identifier and description as fields. Refs SHOOP-2117 / SHOOP-1973

suutari-ai · 2016-03-02T17:28:12Z

This is cool now. Thanks, @tulimaki! :)

Core: option to create payments with REST API

anders-jenkins · 2016-03-03T09:13:43Z

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1596/
Test FAILed.

anders-jenkins · 2016-03-03T11:56:48Z

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1597/
Test FAILed.

anders-jenkins · 2016-03-03T14:44:29Z

Refer to this link for build results (access rights to CI server needed):
http://spartacus.aintra:8080//job/shoop-ng-pull-requests/1599/
Test FAILed.

tulimaki force-pushed the create_payment_api branch 2 times, most recently from aebfa31 to 8bd3362 Compare February 5, 2016 03:21

tulimaki force-pushed the create_payment_api branch from 8bd3362 to f2d3dc2 Compare February 5, 2016 19:30

tulimaki force-pushed the create_payment_api branch from f2d3dc2 to 6297e1a Compare February 5, 2016 20:59

tulimaki force-pushed the create_payment_api branch from 6297e1a to 3690ecf Compare February 8, 2016 18:59

tulimaki force-pushed the create_payment_api branch from 3690ecf to f407f80 Compare February 8, 2016 21:20

tulimaki changed the title ~~Core: add API for creating payments~~ Core: option to create payments with REST API Feb 8, 2016

akx reviewed Feb 9, 2016
View reviewed changes

tulimaki force-pushed the create_payment_api branch from f407f80 to 51c7cbc Compare February 9, 2016 18:45

tulimaki force-pushed the create_payment_api branch from 51c7cbc to 9f11d51 Compare February 10, 2016 20:56

tulimaki force-pushed the create_payment_api branch from 9f11d51 to 751df2b Compare February 10, 2016 22:30

tulimaki force-pushed the create_payment_api branch from 751df2b to 24e0435 Compare February 20, 2016 09:43

suutari-ai reviewed Mar 2, 2016
View reviewed changes

Core: Add option to create payments with REST API

6bb7215

* Add create_payment detail route to OrderViewSet * add set_fully_paid detail route to OrderViewSet * Add PaymentSerializer with amount_value, payment_identifier and description as fields. Refs SHOOP-2117 / SHOOP-1973

tulimaki force-pushed the create_payment_api branch from 24e0435 to 6bb7215 Compare March 2, 2016 17:20

suutari-ai added a commit that referenced this pull request Mar 2, 2016

Merge pull request #342 from tulimaki/create_payment_api

3d49b5f

Core: option to create payments with REST API

suutari-ai merged commit 3d49b5f into shuup:master Mar 2, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Core: option to create payments with REST API #342

Core: option to create payments with REST API #342

tulimaki commented Feb 5, 2016

anders-jenkins commented Feb 5, 2016

anders-jenkins commented Feb 5, 2016

anders-jenkins commented Feb 5, 2016

anders-jenkins commented Feb 5, 2016

anders-jenkins commented Feb 5, 2016

akx commented Feb 8, 2016

akx commented Feb 8, 2016

Pikkupomo commented Feb 8, 2016

tulimaki commented Feb 8, 2016

anders-jenkins commented Feb 8, 2016

anders-jenkins commented Feb 8, 2016

akx Feb 9, 2016

anders-jenkins commented Feb 9, 2016

akx commented Feb 10, 2016

tulimaki commented Feb 10, 2016

anders-jenkins commented Feb 10, 2016

anders-jenkins commented Feb 10, 2016

tulimaki commented Mar 1, 2016

suutari-ai Mar 2, 2016

suutari-ai commented Mar 2, 2016

anders-jenkins commented Mar 3, 2016

anders-jenkins commented Mar 3, 2016

anders-jenkins commented Mar 3, 2016

Core: option to create payments with REST API #342

Core: option to create payments with REST API #342

Conversation

tulimaki commented Feb 5, 2016

anders-jenkins commented Feb 5, 2016

anders-jenkins commented Feb 5, 2016

anders-jenkins commented Feb 5, 2016

anders-jenkins commented Feb 5, 2016

anders-jenkins commented Feb 5, 2016

akx commented Feb 8, 2016

akx commented Feb 8, 2016

Pikkupomo commented Feb 8, 2016

tulimaki commented Feb 8, 2016

anders-jenkins commented Feb 8, 2016

anders-jenkins commented Feb 8, 2016

akx Feb 9, 2016

Choose a reason for hiding this comment

anders-jenkins commented Feb 9, 2016

akx commented Feb 10, 2016

tulimaki commented Feb 10, 2016

anders-jenkins commented Feb 10, 2016

anders-jenkins commented Feb 10, 2016

tulimaki commented Mar 1, 2016

suutari-ai Mar 2, 2016

Choose a reason for hiding this comment

suutari-ai commented Mar 2, 2016

anders-jenkins commented Mar 3, 2016

anders-jenkins commented Mar 3, 2016

anders-jenkins commented Mar 3, 2016