Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] LPS-79753 #6032

Closed
wants to merge 896 commits into from
Closed

[TS] LPS-79753 #6032

wants to merge 896 commits into from

Conversation

yuhai
Copy link

@yuhai yuhai commented Apr 26, 2018

Hi @shuyangzhou

Hope you are well. :)

Please refer to the explanation from #6018 (comment).

cc @hhuijser

Regards,
Hai

pavel-savinov and others added 30 commits April 24, 2018 19:37
…of dropdownitem instead of clay DropdownItemList
… permission check based on the version of the file entry
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@yuhai yuhai mentioned this pull request Apr 26, 2018
@shuyangzhou
Copy link
Owner

See brianchandotcom#57690

@shuyangzhou
Copy link
Owner

The problem you described should not exist as I added the file.exist() check.
If there is any more problems, create an unit test to show it, it is much more easier and accurate than describing it by words.

@yuhai yuhai mentioned this pull request Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet