Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for freezing ingress TLS secrets #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnmdilley
Copy link

Per https://kubernetes.io/docs/concepts/services-networking/ingress/ ingress resources consume secrets, so these should be frozen too.

There was an issue with the parsing code where the [*] came just before the final key - I believe the fix below solves the issue without breaking other cases.

@shyiko
Copy link
Owner

shyiko commented Feb 6, 2019

Hey John. Thanks for the PR! Any chance you'd be willing to add a test case for [*]?

@johnmdilley
Copy link
Author

I believe that's covered implicitly in the example files by exercising the TLS secrets - i.e. 9dd9fb4#diff-3923b468d951d238ab424ff3c20097c9R75 has the frozen secret, which uses the rule at 9dd9fb4#diff-3923b468d951d238ab424ff3c20097c9R75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants