Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MariaDB GTID #50

Closed
wants to merge 54 commits into from
Closed

Support MariaDB GTID #50

wants to merge 54 commits into from

Conversation

wenerme
Copy link

@wenerme wenerme commented Jun 13, 2015

#49

@wenerme
Copy link
Author

wenerme commented Jun 13, 2015

The error is caused by checkstyle, my code style is different from the checkstyle

@shyiko
Copy link
Owner

shyiko commented Jun 17, 2015

Hey @wener. Thank you for the contribution! I intend to merge this in but I'll have to squash and change quite a bit in order to keep backward compatibly and formatting / code style intact, first.

@wenerme
Copy link
Author

wenerme commented Jun 17, 2015

That's ok, for backward compatibly may need expose gtidSet, but I think this added in recently, still can break now, consider a new release ?

…gtid set, will use master current position instead start from begin.
@shyiko shyiko mentioned this pull request Apr 11, 2016
@magicdoom
Copy link

@shyiko Can this merge please? We need mariadb support

@magicdoom
Copy link

BinaryLogClient.java 1081 line: if ("gtid_current_pos".equals(gtid) || "".equals(gtid)) {

should be if ("gtid_current_pos".equals(gtid) || "".equals(gtid)||gtid==null) {

add a "gtid==null" condition

@shyiko
Copy link
Owner

shyiko commented Dec 10, 2016

@magicdoom

The only reason this hasn't been merged is a project scope widening. If I were to merge it I'd have to add MariaDB-specific tests (which this PR is missing), fix any critical MariaDB-specific issues (like #53) and more importantly be ready to provide basic user support. With the amount of free time I have I'd rather make sure that a few years from now this project is still going to be active. So you know, it basically comes down to a sustainability.

If you are willing to invest some of your time and create a MariaDB fork (say mariadb-binlog-connector-java) - I'd gladly add a link to it in readme.md.

@Trigl
Copy link

Trigl commented Jun 17, 2021

Do we support MariaDB gtid now? Or is there an available library to use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants