New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support MariaDB GTID #50
Conversation
The error is caused by checkstyle, my code style is different from the checkstyle |
Hey @wener. Thank you for the contribution! I intend to merge this in but I'll have to squash and change quite a bit in order to keep backward compatibly and formatting / code style intact, first. |
That's ok, for backward compatibly may need expose gtidSet, but I think this added in recently, still can break now, consider a new release ? |
…gtid set, will use master current position instead start from begin.
…ts would pass on 5.6 with binlog_checksum=CRC32)
@shyiko Can this merge please? We need mariadb support |
BinaryLogClient.java 1081 line: if ("gtid_current_pos".equals(gtid) || "".equals(gtid)) { should be if ("gtid_current_pos".equals(gtid) || "".equals(gtid)||gtid==null) { add a "gtid==null" condition |
The only reason this hasn't been merged is a project scope widening. If I were to merge it I'd have to add MariaDB-specific tests (which this PR is missing), fix any critical MariaDB-specific issues (like #53) and more importantly be ready to provide basic user support. With the amount of free time I have I'd rather make sure that a few years from now this project is still going to be active. So you know, it basically comes down to a sustainability. If you are willing to invest some of your time and create a MariaDB fork (say |
Do we support MariaDB gtid now? Or is there an available library to use? |
#49