WIP: MPRIS

[rubdos]

PR for early feedback.

todo:

• rustfmt

[shymega]

Looks good so far, I'll probably make some changes once merged however. I like the event-driven changes, I think that suits the purpose better.

I need to change the new() method on the Song struct to use String::new() instead of "".to_string(). I don't know why I did that. I guess that was when I was a bit new to Rust!

As we discussed on IRC, there's some changes that need to be made upstream, so I won't merge this PR just yet, given that it fails on CI, and that we're waiting on upstream (mpris-rs) to review your issue you made.

Otherwise, good job! 👍

[rubdos]

I need to change the new() method on the Song struct to use String::new() instead of "".to_string(). I don't know why I did that. I guess that was when I was a bit new to Rust!

Wrt. to that, there's a #[derive(Default)] on struct Song; why not just use that for the time being? ;-)

[shymega]

@rubdos I can make the change on master, I just don't want to mess up your PR. Would you mind if I made a few changes on master?

[rubdos]

@rubdos I can make the change on master, I just don't want to mess up your PR. Would you mind if I made a few changes on master?

What's the change you have in mind? Getting rid of new()? FYI: I'm on IRC if you want quicker response :-)

[rubdos]

I just (finally) incorporated a PoC for Mange/mpris-rs#36 .

scrobble starting NOW..
mpris event Ok(Playing)
Event: NowPlaying(Song { title: "", album: "", artist: "", album_artist: "", date: "", genre: "", track: "", composer: "" })
mpris event Ok(Paused)
mpris event Ok(Playing)
Event: NowPlaying(Song { title: "", album: "", artist: "", album_artist: "", date: "", genre: "", track: "", composer: "" })

(Song doesn't get filled yet)

[shymega]

@rubdos PR looks good. Don't worry about filing the song. I'll do the DB stuff :-)

There is a conflict with Cargo.{lock,toml}, which I'd like to see resolved in the PR before I merge.

Thank you for your contribution to scrobble.rs! :+1

[rubdos]

There is a conflict with Cargo.{lock,toml}, which I'd like to see resolved in the PR before I merge.

Would you merge it as-is for the rest? Because it's just a PoC at this point :'-)

[shymega]

I'll see if I can merge it, but I'll be merging into a development branch for the MPRIS branch, and not into master if at all.

I would prefer that more testing is done on the PR itself before merging into the main codebase.

[shymega]

I have merged your PR into the codebase as of 18bc111, which seems to be working correctly.

As I have merged the PR, it will now be closed. Please do open another PR for future improvements. Many thanks for your contribution!