Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

keyboard_response: variably defined allowed response throws TypeError #128

Closed
smathot opened this issue Mar 5, 2019 · 3 comments
Closed

keyboard_response: variably defined allowed response throws TypeError #128

smathot opened this issue Mar 5, 2019 · 3 comments
Assignees
@dschreij
Labels
bug Needs review
Projects
OSWeb 1.3

Comments

@smathot
Copy link
Collaborator

smathot commented Mar 5, 2019

If you specify a variable in the allowed-responses field of a keyboard_response, a TypeError is thrown:

image
@smathot smathot added the bug label Mar 5, 2019
@smathot smathot added this to To do in OSWeb 1.3 via automation Mar 5, 2019
@dschreij
Copy link
Collaborator

This should be fixed by #132

@dschreij dschreij moved this from To do to In progress in OSWeb 1.3 Mar 11, 2019
smathot added a commit that referenced this issue Mar 12, 2019
@smathot
Update attentional-capture experiment to use variably defined allowed…
d36891b 
… responses

- related to #128 and #132
@dschreij
Copy link
Collaborator

dschreij commented Apr 16, 2019 •
edited

Can you please review this one, and see if it is fixed? :) I'm starting with a minor cleanup of the issues to reduce the (visual) clutter.

@dschreij
Copy link
Collaborator

dschreij commented Apr 16, 2019 •
edited

Oh right, I looked at the PR and see that it's already been merged into 1.3. Yay! Closing...

OSWeb 1.3 automation moved this from In progress to Done Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dschreij dschreij

Labels
bug Needs review
Projects
OSWeb 1.3
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smathot @dschreij