Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DelegateCommands background feature into seperate class #295

Open
simonsilvalauinger opened this issue Aug 17, 2015 · 2 comments
Open

Move DelegateCommands background feature into seperate class #295

simonsilvalauinger opened this issue Aug 17, 2015 · 2 comments
Labels
API breaking change Commands Difficulty: Medium improvement Ready for implementation
Milestone
1.9.0

Comments

@simonsilvalauinger
Copy link

I propose to move the background execute behavior of the DelegateCommand class into a seperate class, e.g. BackgroundDelegateCommand or AsyncDelegateCommand. This class could be a subclass of DelegateCommand. It would be cleaner code and would give more semantik to the code.

Regards,
Simon
@manuel-mauky
Copy link
Collaborator

Hi Simon,
thanks for your proposal.
'AsyncDelegateCommand' sounds good to me.

@sialcasa what's your opinion?

@manuel-mauky manuel-mauky changed the title Move DelegateCommands background feature into seperate class [commands] Move DelegateCommands background feature into seperate class Sep 4, 2015
@sialcasa
Copy link
Owner

sialcasa commented Sep 4, 2015

+1

@manuel-mauky manuel-mauky added this to the 1.7.0 milestone Feb 3, 2017
@manuel-mauky manuel-mauky changed the title [commands] Move DelegateCommands background feature into seperate class Move DelegateCommands background feature into seperate class Jun 9, 2017
@manuel-mauky manuel-mauky modified the milestones: 1.7.0, 1.8.0 Sep 20, 2017
@manuel-mauky manuel-mauky modified the milestones: 1.8.0, 1.9.0 Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API breaking change Commands Difficulty: Medium improvement Ready for implementation
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
3 participants
@manuel-mauky @sialcasa @simonsilvalauinger