Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rainmachine | Replaced duplicated string literals with constants #5

Conversation

1onemike
Copy link
Collaborator

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • [ x] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: Duplicated string literals
  • Link to documentation pull request:

Checklist

  • [ x] The code change is tested and works locally.
  • [x ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ x] There is no commented out code in this PR.
  • [x ] I have followed the development checklist
  • [x ] I have followed the perfect PR recommendations
  • [x ] The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@siamzam siamzam merged commit c56b768 into dev Oct 10, 2023
13 of 14 checks passed
@1onemike 1onemike changed the title Replaced duplicated string literals with constants Rainmachine | Replaced duplicated string literals with constants Oct 12, 2023
petranissan pushed a commit that referenced this pull request Nov 13, 2023
Draft: Resolve "Rebase with the latest upstream/dev"

Closes #5

See merge request group-91450937/core!2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants