Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add single precision (float32) mode #70

Merged
merged 2 commits into from
Jan 29, 2024
Merged

add single precision (float32) mode #70

merged 2 commits into from
Jan 29, 2024

Conversation

zjzjwang
Copy link

@zjzjwang zjzjwang commented Jan 27, 2024 •
edited

Closes #69

mostly copy from this branch vecterize

siboehm
siboehm requested changes Jan 28, 2024
View reviewed changes
Copy link
Owner

@siboehm siboehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great stuff! Thank you for implementing it, changes look good apart from some minor interface & variable naming issues.

lleaves/compiler/codegen/codegen.py Outdated Show resolved Hide resolved
lleaves/compiler/codegen/codegen.py Outdated Show resolved Hide resolved
lleaves/compiler/tree_compiler.py Outdated Show resolved Hide resolved
lleaves/data_processing.py Outdated Show resolved Hide resolved
lleaves/lleaves.py Outdated Show resolved Hide resolved
lleaves/lleaves.py Outdated Show resolved Hide resolved
tests/test_benchmark.py Show resolved Hide resolved
siboehm
siboehm requested changes Jan 28, 2024
View reviewed changes
Copy link
Owner

@siboehm siboehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great stuff! Thank you for implementing it, changes look good apart from some minor interface & variable naming issues.

@zjzjwang
Copy link
Author

Thank you for your insightful review, and I have made the changes accordingly. If you have any other suggestions, please feel free to let me know.

@siboehm siboehm self-requested a review January 29, 2024 15:58
@siboehm
Copy link
Owner

siboehm commented Jan 29, 2024

LGTM, thanks for the PR @zjzjwang! Will try to do a release on the weekend

@siboehm siboehm merged commit 45d004b into siboehm:master Jan 29, 2024
3 checks passed
@zjzjwang zjzjwang deleted the single_precision branch January 30, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siboehm siboehm siboehm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query on halting single precision support
2 participants
@zjzjwang @siboehm