New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: use lock.extend replace pexpire #128
Conversation
monkey patch lua LUA_EXTEND_TO_SCRIPT close sibson#127
Currently the process will die if it found out that it no longer own the lock:
I think it would be better to make this process get blocked and trying to reacquiring the lock? |
Hi @sibson some tests fails, but it doesn't seem to relevant to this PR. PTAL |
I update the lock extend logic and update readme. What do you think? |
This generally looks good to me. I'm taken the approach of exiting on terminal error conditions rather than deal with the complexity of trying to recover. |
Conflict resolved. PTAL @sibson |
LGTM, thanks. I'm going to see if we can resolve the failing test on master before merging this. If that doesn't happen soon, I'll merge this regardless. |
ping @sibson |
monkey patch lua LUA_EXTEND_TO_SCRIPT
close #127
close #84
close #83