Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server version check #49

Closed
rjahn opened this issue Nov 23, 2022 · 2 comments
Closed

Server version check #49

rjahn opened this issue Nov 23, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rjahn
Copy link
Member

rjahn commented Nov 23, 2022

We need a check for client/server compatibility...

similar to this one: sibvisions/reactUI#343

Best would be a server-side check. Client sends supported server version and server checks with own version!

@rjahn
Copy link
Member Author

rjahn commented Nov 23, 2022

If you send the serverVersion to the server via startup request:

2.0.0 -> 3.0.0 -> Error
2.1.0 -> 2.0.0 -> Error

2.1.0 -> 2.1.1 -> OK
2.1.0 -> 2.2.0 -> OK
2.1.1 -> 2.1.0 -> OK (server has no relevant changes)

A major version change is not allowed.
A minor version change is allowed as long as server version is bigger.

If an error is detected, the server sends a new response:

name: badClient
info: text

e.g.

[ {
  "name" : "badClient",
  "info" : "UI is incompatible with server [1.0.0 ! 2.0.0]"
} ]

@ToniHeiss ToniHeiss added the enhancement New feature or request label Nov 30, 2022
@rjahn rjahn added this to the 2.2.0 milestone Nov 30, 2022
@rjahn
Copy link
Member Author

rjahn commented Dec 7, 2022

Current server version is 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants