Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server sending Versionnumber Support #343

Closed
maximilianweidenauer opened this issue Nov 9, 2022 · 8 comments
Closed

Server sending Versionnumber Support #343

maximilianweidenauer opened this issue Nov 9, 2022 · 8 comments

Comments

@maximilianweidenauer
Copy link
Contributor

At the start, the server should send a version to the client, the client then checks if it is compatible with the server, if not an info is shown and the app is stopped.

@rjahn
Copy link
Member

rjahn commented Nov 9, 2022

server now sends serverVersion property to client (applicationMetaData), e.g. 2.0

We should support major.minor.build.revision

build and revision doesn't require a new client
major or minor changed requires a new client

e.g. 2.1.0.0 -> 2.1.1.0 -> client and server are compatible

We also could move the check to the server? Simply send a serverVersion via startup?

@maximilianweidenauer
Copy link
Contributor Author

I don't mind if the check is on the client, if the versions are not compatible I'm going to show the error-bar with no retry option. I would just need a global variable that has the current working version. How will it be updated? Manually?

@rjahn
Copy link
Member

rjahn commented Nov 23, 2022

server side check would be the best - for all UI technologies.

@maximilianweidenauer
Copy link
Contributor Author

Which Server-Version should I send to the Server? 2.0?

@rjahn
Copy link
Member

rjahn commented Nov 23, 2022

2.0.0

maximilianweidenauer added a commit that referenced this issue Nov 23, 2022
@maximilianweidenauer
Copy link
Contributor Author

now sending 2.0.0 at startup

@maximilianweidenauer
Copy link
Contributor Author

maximilianweidenauer commented Nov 28, 2022

Re-open because I haven't added the Error-Message when the Version is missmatching

@maximilianweidenauer
Copy link
Contributor Author

This is the message I'm displaying. We probably need translation for this?
image

maximilianweidenauer added a commit that referenced this issue Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants