Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm installation failure and cleanup values organization #134

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

cephasara
Copy link

This PR addresses the leftover attribute and command to install a kernel in the pod at runtime. This has been migrated to the Dockerfile itself, so it doesn't take any longer for the pod to start. I accidentally left this in the chart template when I was testing. 😅

Currently, this prevents helm from installing the chart, so this fix is the main reason for this PR.

Additionally, this PR migrates all macOS specific commands out into their own value map so it is a bit cleaner organizationally speaking.

@sickcodes sickcodes merged commit 0541941 into sickcodes:master Jan 24, 2021
@sickcodes
Copy link
Owner

Perfect, thank you again!

@sickcodes
Copy link
Owner

I want to add this to Helm ASAP, I think we need an index.yaml file to do so, are you able to whip one up?

@sickcodes
Copy link
Owner

That would be amazing :) your work is very appreciated!

@sickcodes
Copy link
Owner

Hey @cephasara, finally got around to wrapping my head around this, here's what I did:

git clone https://github.com/sickcodes/Docker-OSX
cd Docker-OSX/helm

helm package .
helm repo index . --url https://github.com/sickcodes/Docker-OSX/helm


https://github.com/sickcodes/Docker-OSX/tree/master/helm

However, I'm getting this error:

An error occurred updating the repository: invalid input: error converting YAML to JSON: yaml: line 89: mapping values are not allowed in this context

Do you have any suggestions how to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants