explicitly set colors to 256 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While testing this color scheme didn't work for me (linux, xfce4-terminal and gnome-terminal; worked on xterm). To be sure, explicitly add 256 colors to the scheme.
|
I believe t_Co should not be set by color schemes. It should rather be respected by them. If you'll run vim in 16-colors only terminal with this scheme it wouldn't display 256 colors anyway. |
|
@sickill I guess it's more from the point that: if sb. uses this theme they'll want 256 color-configuration anyway. For some systems that don't solve this automatically and users that don't know about this option, the theme will initially appear to not work. If you know about this option you'll be fine, but for others it will look problematic. Are there downsides to setting it here? In case you don't want it, i'll close this MR, please let me know ;) |
|
Ok, you convinced me ;). Merging. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing, this color scheme first didn't work for me (linux, xfce4-terminal and gnome-terminal; worked on xterm). To be sure, explicitly call 256 colors for this scheme.