Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port local-{min,max}ima, estimate-global-{min, max} from scmutils [in progress] #108

Closed
wants to merge 2 commits into from
Closed

port local-{min,max}ima, estimate-global-{min, max} from scmutils [in progress] #108

wants to merge 2 commits into from

Conversation

sritchie
Copy link
Member

This will round out the functions in unimin.scm, so I can't help but port them over.

@sritchie sritchie changed the base branch from sritchie/port_minimize to master September 22, 2020 17:37
littleredcomputer
littleredcomputer approved these changes Oct 18, 2020
View reviewed changes
Copy link
Collaborator

@littleredcomputer littleredcomputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all so appealing I want to start using them.

src/sicmutils/numbers.cljc Outdated
(op (u/bigint a) b))

;; For NON integrals, we currently have no choice but to downcast the
;; BigInt to a floating point number. TODO if we introduce BigDecimal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it would depend on who you want to win. In the BigDecimal case, you probably get a horrible fraction out of the float, and the horrible fraction goes on to color everything it touches like a dye marker. At least having float be the absorbing state is closer to the hardware. As an occasional Mathematica user I'm always amused when something I type comes back with Brobdingnagian fractions in it, because I forgot to put a . after one of the numbers to calm it down (or wrap with N[], but then you've paid the cost for a huge amount of ultimately uninteresting rational arithmetic.

@sritchie sritchie marked this pull request as draft October 31, 2020 21:41
@codecov-io
Copy link

codecov-io commented Feb 13, 2021 •
edited

Codecov Report

Merging #108 (96ec24f) into master (dd15e95) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   84.18%   84.18%           
=======================================
  Files          81       81           
  Lines        8434     8434           
  Branches      453      453           
=======================================
  Hits         7100     7100           
  Misses        881      881           
  Partials      453      453

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd15e95...96ec24f. Read the comment docs.

@sritchie sritchie added kernel Remaining items from scmutils kernel. numerical-methods labels Nov 28, 2021
@sritchie sritchie mentioned this pull request Jan 24, 2023
Open
@sritchie sritchie added this to the 0.22.0 milestone Jan 24, 2022
@sritchie sritchie mentioned this pull request Mar 11, 2023
Open
@sritchie
Copy link
Member Author

Moved to Emmy.

@sritchie sritchie closed this Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littleredcomputer littleredcomputer littleredcomputer approved these changes

Assignees
No one assigned
Labels
kernel Remaining items from scmutils kernel. numerical-methods
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sritchie @codecov-io @littleredcomputer