Move function and symbol Value implementations => their respective namespaces
#184
Conversation
| @@ -157,14 +251,6 @@ | |||
| returns a fn that applies them in reverse order. Like a curried andThen (the | |||
| reverse of compose)")))) | |||
|
|
|||
| (deftest string-form-test | |||
There was a problem hiding this comment.
this moved to the simplifier tests.
| (g/+ (s/up 4 3 1) v)) | ||
| (deferred v)) | ||
| "Slightly tougher since this works with structures"))) | ||
| (checking "invert" 100 [n sg/real] |
There was a problem hiding this comment.
these are tests of all the new generic methods implemented for fns.
| (is (= 33 (add+mul 2 3 4))) | ||
| (is (= -15 (add-mul 2 3 4))) | ||
| (is (= 15 (mul-add 2 3 4))))))) | ||
|
|
||
| (deftest operators |
There was a problem hiding this comment.
moved to operator, since "operator" doesn't "exist yet", as far as the function implementation is concerned.
test/sicmutils/generators.cljc
Outdated
| @@ -61,6 +63,9 @@ | |||
| long | |||
| integer])) | |||
|
|
|||
| (def real | |||
There was a problem hiding this comment.
this came in from a previous PR.
| @@ -81,15 +86,57 @@ | |||
| d)] | |||
| (r/rationalize n d)))) | |||
|
|
|||
| (def ^:dynamic *complex-tolerance* 1e-12) | |||
| (defn square-matrix | |||
There was a problem hiding this comment.
I moved this in from matrix_test.cljc so we could start consolidating our generators.
test/sicmutils/generators.cljc
Outdated
| (gen/fmap #(apply m/by-rows %) | ||
| (gen/vector (gen/vector entry-gen n) n)))) | ||
|
|
||
| (defn- int=? [this that] |
There was a problem hiding this comment.
this and the following protocol extension allow all of our real types to compare approximately with complex.
There was a problem hiding this comment.
what does int= mean? Is one of these guaranteed to be complex?
| @@ -237,62 +231,88 @@ | |||
| (is (c/complex? (g/asin 2))) | |||
| (is (c/complex? (g/acos 2)))) | |||
|
|
|||
| (testing "sin" | |||
There was a problem hiding this comment.
woohoo, all of these are now generative tests.
| @@ -140,6 +136,16 @@ | |||
| ::native-integral | |||
| ::floating-point))) | |||
|
|
|||
| #?(:clj Boolean :cljs boolean) | |||
There was a problem hiding this comment.
isn't that the very definition of a bike shed. I think the answer is not obvious (I could argue that the correct answer is "the identity function"), while the stakes are vanishingly low
| (v/real? that) (si/*comparator* | ||
| (u/double this) | ||
| (u/double that)) | ||
| :else (= this that))) | ||
|
|
||
| (extend-protocol si/Approximate |
There was a problem hiding this comment.
Ya learn something new every day!
There was a problem hiding this comment.
The same library has been great... this idea comes up in every damned library. Why can't a language give it to us out of the box??
test/sicmutils/generators.cljc
Outdated
| (gen/fmap #(apply m/by-rows %) | ||
| (gen/vector (gen/vector entry-gen n) n)))) | ||
|
|
||
| (defn- int=? [this that] |
There was a problem hiding this comment.
what does int= mean? Is one of these guaranteed to be complex?
This PR:
Symbolvalue implementation intosicmutils.abstract.numberValueimplementations for the various function types, and moves these (and thearitycode) tosicmutils.function::v/functionApproximateimplementations for our various types, so all numbers now compare appropriately to complex and each other withish?Plus a couple small fixes.