Add metadata implementation to expressions, properly freeze modint #185
Conversation
| (withMeta [_ meta] (Literal. type expression meta))] | ||
|
|
||
| :cljs | ||
| [IMeta |
There was a problem hiding this comment.
Is there a circumstance where you could have Meta but not WithMeta?
There was a problem hiding this comment.
scrolling the cljs source, it looks like you would do this for a type you don't control; the withMeta implementation would have to go onto a wrapper type, MetaFn in the case of functions with cljs.
meta on a bare function returns nil.
There was a problem hiding this comment.
Oh, I was confused. I thought IWithMeta was a name you had chosen.
Are we going to maintain a difference between metadata as we see it and the native implementation?
There was a problem hiding this comment.
Nope, this actually brings us back to how native works!
defrecord gets support for metadata out of the box, so that's why it worked before if it did.
But deftypes don't, so you have to manually carry around the map and implement these protocols.
| (defmethod g/tanh [::matrix] [m] (series/tanh-series m)) | ||
| (defmethod g/asinh [::matrix] [m] (series/asinh-series m)) | ||
| (defmethod g/atanh [::matrix] [m] (series/atanh-series m)) | ||
| (defmethod g/exp [::square-matrix] [m] (series/exp-series m)) |
There was a problem hiding this comment.
I love ::square-matrix, that's a good idea.
sritchie
changed the base branch from
sritchie/move_value_definitions
to
master
This PR:
Literal! We can use this now instead of my hand-rolled thing I was starting to do. Better to stick to Clojure's great interfaces.v/freezeimplementation to modint, another small thing I noticed.