Add vector-set, slight tidying in structure (autodiff #3) #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## sritchie/diff_two #220 +/- ##
====================================================
Coverage ? 84.20%
====================================================
Files ? 79
Lines ? 8072
Branches ? 440
====================================================
Hits ? 6797
Misses ? 835
Partials ? 440 Continue to review full report at Codecov.
|
sritchie
force-pushed
the
sritchie/diff_three
branch
from
1355cf0
to
20e1d3f
Compare
littleredcomputer
approved these changes
Jan 21, 2021
| @@ -0,0 +1,130 @@ | |||
| ;; | |||
There was a problem hiding this comment.
for optimization of differential tags? I wonder if it is worth specializing it to numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "vector set" implementation that we'll use in #221 to implement
Differential. A "vector set" is a vector of distinct, sorted elements, used to represent a set more cheaply than an actual set.Rather than make a
deftypeand make this a real thing that matches the set interface (and perhaps discover in the process that Clojure has already optimized small sets to work just as fast, gulp!), vector sets you make withmakestay correct if you stay inside the supplied API.NOTE for @littleredcomputer - a
(sorted-set)is actually very fast for conj, disj, set operations... but slower to return its greatest element.Also, from the CHANGELOG:
sicmutils.structure/oppositereturns an identicalstructure with flipped orientation (Add vector-set, slight tidying in structure (autodiff #3) #220). acts as
identityfornon-structures.
NOTE: for reference, this idea is also called a "flat set" in boost. Technically a Clojure vector-based set is NOT flat, since vectors are implemented with a hash trie... whatever. Once we start benchmarking maybe we can replace this with a set.