Implement differential protocols for all Clojure collection types (autodiff #5) #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## sritchie/diff_four #222 +/- ##
======================================================
- Coverage 83.96% 83.80% -0.16%
======================================================
Files 80 81 +1
Lines 8470 8523 +53
Branches 456 459 +3
======================================================
+ Hits 7112 7143 +31
- Misses 902 921 +19
- Partials 456 459 +3
Continue to review full report at Codecov.
|
sritchie
added
the
Automatic Differentiation
sritchie
commented
Jan 13, 2021
| @@ -105,7 +105,6 @@ | |||
| `g/sin` has arity [:exactly 1].")))) | |||
|
|
|||
| (deftest arity-tests | |||
| (arity-check identity "vector") | |||
There was a problem hiding this comment.
I had mistakenly implemented arity for vectors to go check the arity of its contained functions. But this is wrong, because if you try to apply a vector (vs an up), Clojure has already provided an IFn implementation that simply looks up entries!
sritchie
force-pushed
the
sritchie/diff_five
branch
from
86f55e4
to
711ad43
Compare
| @@ -2,6 +2,13 @@ | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| - #222 adds `v/Value` implementations for Clojure sequences and maps. Maps and | |||
There was a problem hiding this comment.
Did you consider whether we could just get away with fmap?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the CHANGELOG entry:
Implement differential protocols for all Clojure collection types (autodiff #5) #222 adds
v/Valueimplementations for Clojure sequences and maps. Maps andvectors implement
f/Arityand return[:between 1 2].zero?andzero-likework on sequence entries and map values. Maps can specify theirv/kindreturn value with a:typekey, and some of the calculus implementations do already make use of this feature.g/partial-derivative` ona Clojure Map passes through to its values.
Implement differential protocols for all Clojure collection types (autodiff #5) #222 implements
d/IPerturbedfor Clojure maps, vectors and sequences;all are now valid return types for functions you pass to
D.Implement differential protocols for all Clojure collection types (autodiff #5) #222 also implements
d/IPerturbedfor SICMUtilsMatrix,Structure,Series,PowerSeriesandOperator.