-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[kernel] Change the interafce of computeJachqT from
virtual void computeJachqT(Interaction& inter, SP::DynamicalSystem ds1, SP::DynamicalSystem ds2); to virtual void computeJachqT(Interaction& inter, VectorOfBlockVectors& DSlink ); The interface is now coherent with virtual void computeJachqT(Interaction& inter, VectorOfBlockVectors& DSlink ); and allows a single call to virtual void computeJach(double time, Interaction& inter, InteractionProperties& interProp); throughout the code. The other calls with test on the type of relation are removed This change asks for the deeper question of the evaluation of of the relation. This is done mainly through computeOutput and computeInput. The new interface ensures that the value of q is the same for all the invocation in the computation of computeJacqT. For a given q, we compute JachqT(q) = Jach(q)T(q) Before we had something as JachqT(q) = Jach(d->q()) d->T() end the values of Jach(d->q()) d->T() was not coherent. Now it is coherent but it might raise the convergence problem in the Newton loop since the gradient of T are not computed. We need to think in a more "functional" way all these calls
- Loading branch information
Showing
14 changed files
with
280 additions
and
221 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.