[Numerics] update CSparse #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of CSparse in Numerics is very old (2006). This updates it. Nothing much to note, except: - they change their indices to csi, which is defined to ptrdiff_t if we are not compiling to MATLAB. I kept the name csi when dealing with it in order to ease the transition if this gets renamed - cs_lusol has its signature (order is now the first arg) - the BIGGEST issue is in the css struct, where they use define lnz and unz as double, but use them as pointers in the code. By looking at the function cs_cumsum, it looks like they do that to prevent some overflow ... well the real fix should be to use size_t, but then the logic at the end of cs_schol is broken. I left them as csi (which is like we had before). I don't think we will ever overflow in our case. Feel free to give our opinion.
|
conflicts + compil |
|
Thanks for the review and update. I pushed your branch to master directly to avoid 2 (meaningless merges) |
radarsat1
added a commit
to radarsat1/siconos
that referenced
this pull request
Nov 25, 2016
radarsat1
added a commit
to radarsat1/siconos
that referenced
this pull request
Nov 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of CSparse in Numerics is very old (2006). This commit updates it.
Nothing much to note, except:
are not compiling to MATLAB. I kept the name csi when dealing with it
in order to ease the transition if this gets renamed
unz as double, but use them as pointers in the code. By looking at the
function cs_cumsum, it looks like they do that to prevent some
overflow ... well the real fix should be to use size_t, but then the
logic at the end of cs_schol is broken. I left them as csi (which is
like we had before). I don't think we will ever overflow in our case.
Feel free to give our opinion.