Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide native support for multiple recipients #63

Closed
tdiesler opened this issue Dec 19, 2022 · 3 comments
Closed

Provide native support for multiple recipients #63

tdiesler opened this issue Dec 19, 2022 · 3 comments

Comments

@tdiesler
Copy link
Contributor

tdiesler commented Dec 19, 2022 •
edited

The current version in use is com.nimbusds:nimbus-jose-jwt:9.16-preview.1 (Oct-2021). The final 9.16 release had all the multi encrypt/decrypt stuff removed. Since then it was never introduced back again.

Perhaps we need to find a way to support multiple recipients natively in this project and delegate to nimbus for each recipient
@tdiesler
Copy link
Contributor Author

CrossRef: https://bitbucket.org/connect2id/nimbus-jose-jwt/issues/502/restore-encrypt-decrypt-for-multiple

@tdiesler tdiesler changed the title Upgrade com.nimbusds:nimbus-jose-jwt Upgrade to com.nimbusds:nimbus-jose-jwt:9.25.6 Dec 19, 2022
@tdiesler tdiesler changed the title Upgrade to com.nimbusds:nimbus-jose-jwt:9.25.6 Upgrade to nimbus-jose-jwt-9.25.6 Dec 19, 2022
tdiesler added a commit to tdiesler/didcomm-jvm that referenced this issue Dec 19, 2022
@tdiesler
[sicpa-dlab#63] Upgrade to nimbus-jose-jwt-9.25.6
ca646d0
@tdiesler
Copy link
Contributor Author

tdiesler commented Dec 19, 2022 •
edited

PR: #64

I migrated all 9.16-preview multi classes/interfaces to Kotlin and refactored the code such that stuff related to multiple recipients is now part of this project. Intentionally, I left all those step-by-step micro commits in place for you to verify what actually changed. Each of those commits should be valid (i.e. all tests pass). Feel free to squash if you like.

@tdiesler tdiesler changed the title Upgrade to nimbus-jose-jwt-9.25.6 Provide native support for multiple recipients Dec 19, 2022
tdiesler added a commit to tdiesler/didcomm-jvm that referenced this issue Dec 20, 2022
@tdiesler
[sicpa-dlab#63] Provide native support for multiple recipients
6e9a229
tdiesler added a commit to tdiesler/didcomm-jvm that referenced this issue Feb 15, 2023
@tdiesler
[sicpa-dlab#63] Provide native support for multiple recipients
f2961e0
tdiesler added a commit to tdiesler/didcomm-jvm that referenced this issue Feb 15, 2023
@tdiesler
[sicpa-dlab#63] Provide native support for multiple recipients
9ce2cc5
dkulic pushed a commit that referenced this issue Feb 16, 2023
@tdiesler
Remove shadowing and add POM to generated artifact (#66)
e13012c 
* -- upgrade to kotlin-1.7.20

* -- migrate ECDHDecrypterMulti, ECDHEncrypterMulti

* -- migrate ECDH1PUDecrypterMulti, ECDH1PUEncrypterMulti

* -- migrate ECDH1PUX25519DecrypterMulti, ECDH1PUX25519EncrypterMulti

* -- migrate X25519DecrypterMulti, X25519EncrypterMulti

* -- initial import for JWEObjectJSON

* -- lift encryptMulti, decryptMulti out of ECDHCryptoProvider

* -- migrate JWEDecrypterMulti, JWEEncrypterMulti

* -- migrate JWECryptoParts

* -- migrate JWERecipient

* -- ktlint formatting check

* [#63] Provide native support for multiple recipients

* [#65] Remove shadowing and add POM to generated artifact
@tdiesler
Copy link
Contributor Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tdiesler