Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema stitching #230

Closed
bboure opened this issue Mar 17, 2019 · 8 comments
Closed

schema stitching #230

bboure opened this issue Mar 17, 2019 · 8 comments

Comments

@bboure
Copy link
Collaborator

bboure commented Mar 17, 2019

We recently merged #227 which adds a great addition to the plugin.
However, I just realized that it relies on a deprecated package: https://github.com/okgrow/merge-graphql-schemas

I suggest, we refactor the PR and use Appolo Stitching instead.

@trilliput would you have time to have a look at this?

@shmygol
Copy link
Contributor

shmygol commented Mar 17, 2019

Sorry, I've missed, that merge-grahpql-schemas is deprecated. I'll take a look. No EDD yet.

@bboure
Copy link
Collaborator Author

bboure commented Mar 17, 2019

👍 Let us know if we can help

@shmygol
Copy link
Contributor

shmygol commented Mar 18, 2019

@bboure I'll definitely do it, feel free to assign the issue to me. I'm just not sure when exactly. Approximately this weekend.

@shmygol
Copy link
Contributor

shmygol commented Mar 18, 2019

@bboure How far are you with integrating Amplify CLI https://github.com/aws-amplify/amplify-cli/tree/master/packages/amplify-category-api? It looks promising and if you're already working on integrating it, we might avoid one more intermediate step and concentrate our efforts on Amplify CLI. I'd be glad to help here as well.

@bboure
Copy link
Collaborator Author

bboure commented Mar 18, 2019

@trilliput There is no integration to Amplify CLI on the roadmap yet

There are definitely things that we could explore and that were discussed already, like GraphQL Transformation, for generating resources, data sources and mapping templates.

#62
#211
#151

There is also Codegen

Maybe we could use it somehow under the hood to auto generate

Optionaly, we could add something on top of AWS-cli that does the equivalent of amplify api gql-compile in the package you are refering to, but for serverless (this plugin).

All ideas and PRS are welcome :)

@jasonlimantoro
Copy link

Does this mean we cannot use the extend keyword used in Apollo Stitching?

@vicary
Copy link
Contributor

vicary commented Aug 19, 2019

I believe we basically need this to convert Apollo schemas into AppSync version.

Dug very deep on Sunday and made appsync-schema-converter.

I don't think I can finish it on my own, looking for contributors to cover all directives and edge cases.

@bboure
Copy link
Collaborator Author

bboure commented Dec 13, 2019

Closing this issue as merge-graphql-schemas is now back into maintenance...
... And Apollo deprecated their own Schema Stitching ¯\_(ツ)_/¯

@bboure bboure closed this as completed Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants