Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify lambda datasource config #215

Merged
merged 3 commits into from Feb 28, 2019
Merged

Conversation

bboure
Copy link
Collaborator

@bboure bboure commented Feb 25, 2019

Basically, this will simplify lambda datasources and allow you to do

- type: AWS_LAMBDA
    name: myLambdaDatasource
    description: 'My Lambda Datasource'
    config:
      functionName: myLambda

Where myLambda is the key name of your lambda in your serverless.yml

instead of

- type: AWS_LAMBDA
    name: myLambdaDatasource
    description: 'My Lambda Datasource'
    config:
      lambdaFunctionArn: { Fn::GetAtt: [MyLambdaLambdaFunction, Arn] }

This will also work with AppSync Emulator, and will prevent you from having to do this:

- type: AWS_LAMBDA
    name: myLambdaDatasource
    description: 'My Lambda Datasource'
    config:
      functionName: myLambda
      lambdaFunctionArn: { Fn::GetAtt: [MyLambdaLambdaFunction, Arn] }

@bboure bboure force-pushed the feature/simplify-lambda-datasources branch from 177701f to c1960f0 Compare February 25, 2019 12:06
@bboure bboure changed the title [WIP] Simplify lambda datasource config Simplify lambda datasource config Feb 25, 2019
@bboure bboure requested a review from sid88in February 25, 2019 12:07
@bboure
Copy link
Collaborator Author

bboure commented Feb 25, 2019

Any review from anyone that has a fresh/recent view on the code is welcome.

@bboure bboure merged commit 5923202 into master Feb 28, 2019
@bboure bboure deleted the feature/simplify-lambda-datasources branch February 28, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant