New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Caching #288
Implement Caching #288
Conversation
@michaelrhoden Want to help testing this? |
@bboure - Is this tested or do you need any help? I've created a PR to your branch (feature/caching) to fix the failing snapshots. |
@rakeshmenon I haven't tested this (yet). |
@bboure I was not able to get it to work. I tried using it by changing the package version to: I added the caching configuration in serverless.yml as follows - Under appSync:
Under each mapping template:
It was an update stack operation - as the AppSync endpoint already exists. The update stack operation went through - but did not enable the caching options in the resolvers or change the global caching config. Let me know what you need from my end to debug this issue. |
THank you @rakeshmenon for testing this. instead of changing your package.json, you can also try to use npm link or yarn link |
29bb099
to
56e9171
Compare
Fixed some issues and this is almost working as expected. |
56e9171
to
a897bd5
Compare
w00t! I'll test this out today. Hopefully the Cloudformation issue gets addressed soon :) |
Have tested this PR - I faced the same issue. Caching at the resolver level is not clearing when I removed caching config. Everything else works fine! |
Fixes
a897bd5
to
0302815
Compare
Cfn bug has been confirmed by AWS. After testing this on |
Hi @bboure - when will the new version of the plugin be published with this change included? |
@rakeshmenon the plan is to release soon. |
@rakeshmenon This is now part of the v1.2.0 release. Enjoy! |
Resolves #276