Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add an explanation for excludeVerboseContent #439

Merged

Conversation

lulzneko
Copy link
Contributor

Objective

Add a description of the excludeVerboseContent option to the documentation.

Detail

  • Clarified the default value of the excludeVerboseContent option.
  • Added supplementary information because CFn setting values and AppSync settings have opposite meanings.

@lulzneko
Copy link
Contributor Author

This pull request is only for documentation changes and has nothing to do with errors in CI.

The Lint error in CI is resolved by the pull request in #440.

After the Lint error is resolved, the next error is the Test error.
Test error, which will be resolved in the #441 pull request.

@bboure
Copy link
Collaborator

bboure commented Oct 23, 2021

LGTM, thanks @lulzneko
plus just don't commit yarn-error.log (let's add it to .gitignore

@lulzneko
Copy link
Contributor Author

@bboure
yarn-error.log was an unnecessary commit. Sorry about that.
I have removed yarn-error.log from the pull request.

@lulzneko lulzneko force-pushed the refactor/docs-add-excludeVerboseContent branch from a288430 to 819832b Compare October 24, 2021 09:40
@bboure bboure merged commit 3753515 into sid88in:master Oct 24, 2021
@bboure
Copy link
Collaborator

bboure commented Oct 24, 2021

Thank you!

@lulzneko lulzneko deleted the refactor/docs-add-excludeVerboseContent branch October 25, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants