Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update serverless minimum requirement #451

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Conversation

ankon
Copy link
Contributor

@ankon ankon commented Nov 19, 2021

This was introduced with #400

@bboure
Copy link
Collaborator

bboure commented Nov 19, 2021

Thank you @ankon !

Out of curiosity, what broke?
I checked the PR and it only changes Cloudformation compilation.
How is the sls version breaking it?

@ankon
Copy link
Contributor Author

ankon commented Nov 19, 2021

Nothing broke ;)

I was looking into updating our version, and as part of that read through the PRs and noticed this mismatch.

Given that both 1.30 and 1.83 are really old this shouldn't really change anything for anyone, I guess.

@bboure
Copy link
Collaborator

bboure commented Feb 12, 2022

@ankon sorry, left this open for too long.
I'm still trying to understand where the mismatch comes from though.
Could you clarify?

Thanks

@ankon
Copy link
Contributor Author

ankon commented Feb 12, 2022

Seriously, this is purely a "typo-fix" in the docs to match what package.json says.

@bboure bboure changed the title Update serverless minimum requirement doc: Update serverless minimum requirement Jun 2, 2022
@bboure bboure merged commit d152217 into sid88in:master Jun 2, 2022
@ankon ankon deleted the patch-2 branch June 3, 2022 10:04
@github-actions
Copy link

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants