Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support associating WAF without creating #501

Merged
merged 6 commits into from
Jun 11, 2022
Merged

feat: support associating WAF without creating #501

merged 6 commits into from
Jun 11, 2022

Conversation

rikhilrai
Copy link
Contributor

@rikhilrai rikhilrai commented May 31, 2022 •
edited
Loading

closes #500

Example serverless configuration:

wafConfig:
  enabled: true
  arn: arn:aws:waf-regional:<region>:<account-id>:rule/<rule-id>

@rikhilrai
Copy link
Contributor Author

Raising a draft PR for now. Will wait for comments/suggestions before adding/updating tests & README

@rikhilrai rikhilrai mentioned this pull request Jun 1, 2022
Closed
@bboure
Copy link
Collaborator

bboure commented Jun 2, 2022

LGTM.

Would you mind adding some tests to cover this?

Also, if you got time, would you mind porting this same change to v2 alpha?

@rikhilrai rikhilrai mentioned this pull request Jun 2, 2022
Merged
@rikhilrai
Copy link
Contributor Author

rikhilrai commented Jun 2, 2022 •
edited
Loading

@bboure

Thanks. Added a test 👍
Separate PR with v2 alpha base branch: #504

@rikhilrai
Copy link
Contributor Author

@bboure re #504 (comment), I've updated the README. Is there another doc I should update?

bboure
bboure approved these changes Jun 11, 2022
View reviewed changes
Copy link
Collaborator

@bboure bboure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks!

@bboure bboure merged commit 4c283f0 into sid88in:master Jun 11, 2022
@rikhilrai rikhilrai deleted the patch-1 branch July 6, 2022 17:13
@github-actions
Copy link

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboure bboure bboure approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for associating an exising WAF
2 participants
@rikhilrai @bboure