fix : support overrideAction for WAF #582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #578.
When v1 to v2 migration, overrideAction in WAF code was missed to migrate.
override action is typically
None: {}
, orCount : {}
https://docs.aws.amazon.com/waf/latest/APIReference/API_OverrideAction.html
I referred around this code in v1 branch.
If
overrideAction
is set, useoverrideAction
. Otherwise,Action
is used same as before.https://github.com/sid88in/serverless-appsync-plugin/blob/v1.14.0/src/index.js#L1612
tested with AWS
sls deploy
suceeded