Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitation: DHCP-Managed Hosts and SECURITY_ORIGIN Configuration in WebAPI #48

Open
ThanePi opened this issue Sep 13, 2023 · 0 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@ThanePi
Copy link
Collaborator

ThanePi commented Sep 13, 2023

One of environment variable SECURITY_ORIGIN in OHDSI/WebAPI is related to CORS was designed for static value to reach address of its WebAPI from ATLAS. (as code below)

https://github.com/sidataplus/omop-core/blob/a39556cd3f0e8f00c424050303acfb124dbf19ca/container/module/OHDSI/WebAPI/WebAPI-compose.yaml#L56C7-L58C47

The default value is pointing directly to localhost or 127.0.0.1 for single machine working purpose and will occur an error when using another machine in the network, to fix this problem the value of SECURITY_ORIGIN should be "the actual IP address of WebAPI host machine" but this limitation would not possible when host machine cannot be assigned with dedicate IP address, or have to re-obtain DHCP every fixed period of time.

image

Note: Screenshot from non-host machine when test with same LAN network with host machine.

Current approach would be disable SECURITY_CORS_ENABLED but may not recommended.

@ThanePi ThanePi added enhancement New feature or request wontfix This will not be worked on labels Sep 13, 2023
@ThanePi ThanePi mentioned this issue Sep 17, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant