Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Replace fixed list of devices by a BLE scan #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Djebouh
Copy link

@Djebouh Djebouh commented May 4, 2019

The list of devices is now dynamic. The BLE scan has a duration of BLE_SCAN_DURATION. It looks for devices with root UUID matching 0xfe95 (flora device identifier).
Then the initial processing is applied on each device.

This should address issue #19

@Matz88
Copy link

Matz88 commented May 4, 2019

Now it just tries to process all the flora devices around... is it not better to scan and then process only the one in the list? I did that for my local version.

@Djebouh
Copy link
Author

Djebouh commented May 4, 2019

In my case, it is easier to have a full dynamic list. I don't have neighbor using Flora, and I could filter out in MQTT if need be. I prefer to have the config in the MQTT (that I can access remotely), than on the ESP (which I need to connect to).
Then, even if multiple ESP scan the same devices, this will "only" add another value, I don't see it as a potential conflict.
But this is not an issue as well to add a filter that is either a list of address to keep or empty (no filtering). It could match both use cases :).

@tobiasfaust
Copy link

hi,
its possible to merge it into dev-branch? Or at least to update your PullRequest along current dev-branch?
Maybe, an enhancement: to disable a MAC-Adress via WebForm from scanning

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants