GITHUB_TOKEN is used instead of BUNDLESIZE_GITHUB_TOKEN when present

[oliverviljamaa]

Do you want to request a feature or report a bug?
Bug.

What is the current behavior?
GITHUB_TOKEN environment variable (although undocumented) is used instead of BUNDLESIZE_GITHUB_TOKEN when present. This results in bundlesize checks being authored by the owner of GITHUB_TOKEN rather than the owner of BUNDLESIZE_GITHUB_TOKEN (causing the wrong avatar and issues with the message).

If the current behavior is a bug, please provide the steps to reproduce.

1. Set GITHUB_TOKEN as your personal access token (created here: https://github.com/settings/tokens) in CI.
2. Set BUNDLESIZE_GITHUB_TOKEN as the bundlesize token (retrieved as a result of authorizing the bundlesize application) in CI.
3. Run bundlesize in CI.
4. The GitHub status check will be authored by your account, not bundlesize, as it should.

What is the expected behavior?
BUNDLESIZE_GITHUB_TOKEN is preferred when both GITHUB_TOKEN and BUNDLESIZE_GITHUB_TOKEN are present (as it is more specific and allows having the other token for various other checks). The fact that GITHUB_TOKEN is checked as a fallback is documented.
or
Only BUNDLESIZE_GITHUB_TOKEN is considered.

Please mention other relevant information.

• node v8.12.0
• npm v6.4.1
• bundlesize v0.17.0
• CircleCI

[quantizor]

This can be closed now