Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify on bundle size *decrease*? #38

Closed
tizmagik opened this issue Jul 5, 2017 · 2 comments
Closed

Notify on bundle size *decrease*? #38

tizmagik opened this issue Jul 5, 2017 · 2 comments
Labels

Comments

@tizmagik
Copy link
Contributor

tizmagik commented Jul 5, 2017

Let's say bundle.js starts at 50KB, so we set threshold to 55KB. Then, some incredible PR comes in and reduces the bundle to 40KB -- that's great! 😃 But, now our threshold is still at 55KB 😢

Ideally we'd like to know about this and be reminded to update the bundlesize threshold to something better, like 45KB, for example.

Thoughts?

@siddharthkp
Copy link
Owner

bundlesize does inform you about decrease in size as well. You would see something like this on your terminal/github status:

PASS ./dist.js: 40kB < threshold 55kB gzip (10kB smaller than master, good job!)

That should be in indicator to improve your threshold.

@tizmagik
Copy link
Contributor Author

tizmagik commented Jul 6, 2017

Oh awesome! Sorry, was just looking at the comment block here and didn't actually read through the conditional logic. This is great, thanks!

@tizmagik tizmagik closed this as completed Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants